[PATCH] D16208: [docs] Document LLVM_{BUILD,LINK}_LLVM_DYLIB

[Dan Liew via llvm-commits]

delcypher added a comment.

Looks like this got merged before I was able to comment on this.


================
Comment at: docs/CMake.rst:443
@@ +442,3 @@
+**LLVM_BUILD_LLVM_DYLIB**:BOOL
+  If enabled, the target for building the libLLVM shared library is added.
+  Defaults to OFF. This cannot be used in conjunction with BUILD_SHARED_LIBS.
----------------
I would consider expanding a little

```
If enabled, the target for building the libLLVM shared library is added.
This library contains all of LLVM's components in a single shared library. 
Defaults to OFF. This cannot be used in conjunction with BUILD_SHARED_LIBS=ON.
Tools will only be linked to the libLLVM shared library if LLVM_LINK_LLVM_DYLIB is also ON.
The components in the library can be customised by setting LLVM_DYLIB_COMPONENTS
to a list of the desired components.
```

================
Comment at: docs/CMake.rst:454
@@ +453,3 @@
+**BUILD_SHARED_LIBS**:BOOL
+  Flag indicating if shared libraries will be built instead of static
+  libraries. Its default value is OFF. On Windows, shared libraries may
----------------
I would consider rewording to

```
Flag indicating if each LLVM component (e.g. Support) is built as a shared library (ON) or as a static
library (OFF). Its default value is OFF. On Windows, shared libraries may
be used when building with MinGW, including mingw-w64, but not when
building with the Microsoft toolchain.
```


http://reviews.llvm.org/D16208