[PATCH] D9887: [DebugInfo][FastISel] Prevent using debug location from previous block for local values

[Paul Robinson via llvm-commits]

probinson added a comment.

In http://reviews.llvm.org/D9887#327543, @echristo wrote:

> See the other solution that I mentioned :)


I did, and I've asked the debugger lead. Hopefully will have an answer tomorrow (he's in England).

Looking at the original example, it sounds like you're suggesting we would produce something like this:

  BB#0:
      .loc 1 2 3
      call ...
      <constant load>
      .loc 1 5 6
      ...
  
  BB#1:
      .loc 1 0 0
      <constant load>
      .loc 1 3 4
      ...

Am I understanding this correctly? It sure would be less bookkeeping.

I guess for single-stepping purposes, we want the debugger to just keep going until it found an instruction with a non-zero line number.  For interspersed-source-display purposes, the line-zero instruction would want to be associated with .loc 1 3 4 rather than .loc 1 5 6.


Repository:
  rL LLVM

http://reviews.llvm.org/D9887