[PATCH] D10920: Unify isSafeToLoadUnconditionally and isDereferenceablePointer

Philip Reames via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 14 17:25:19 PST 2016


reames added a subscriber: reames.
reames added a comment.

Artur I spoke this morning about ways to decompose this patch into easier to review chunks.  I believe he plans to separate out at least two small patches to reduce the diff size.  Specifically:

1. One change to the order of arguments to isSafeToLoadUnconditionally.  This is simply to reduce confusing diff lines and will go in directly without further review.
2. One change to push down isDereferenceablePointer down into isSafeToLoadUnconditionally.  This will remove most of the transform pass differences.  This will need review, but should be quick to examine.

Once those two are in, this patch should become much simpler.


http://reviews.llvm.org/D10920





More information about the llvm-commits mailing list