[PATCH] D16176: Introduce stats and stats_client libraries.

Peter Collingbourne via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 14 16:46:11 PST 2016


pcc added inline comments.

================
Comment at: lib/sanitizer_common/sanitizer_flags.cc:51
@@ -50,1 +50,3 @@
+// %p = pid
+void SubstituteForFlagValue(const char *s, char *out, uptr out_size) {
   char *out_end = out + out_size;
----------------
krasin1 wrote:
> why? not that I insist, I just probably don't understand the constraints and interested to learn about that.
If the C++ standard library is compiled with sanitizer instrumentation, we would have a circular dependency between sanitizer_common and the stdlib.


http://reviews.llvm.org/D16176





More information about the llvm-commits mailing list