[PATCH] D16070: [asan] Optionally print reproducer cmdline in ASan reports.

[Kostya Serebryany via llvm-commits]

kcc accepted this revision.
kcc added a comment.
This revision is now accepted and ready to land.

LGTM with a nit


================
Comment at: lib/sanitizer_common/sanitizer_common.cc:495
@@ +494,3 @@
+  Printf("\nCommand: ");
+  for (uptr i = 0; argv[i] != 0; ++i)
+    Printf("%s ", argv[i]);
----------------
either use "argv[i] != nullptr"  or just "argv[i]"

================
Comment at: lib/sanitizer_common/sanitizer_flags.inc:204
@@ +203,2 @@
+COMMON_FLAG(bool, print_cmdline, false, "Print command line on crash "
+            "(asan only).")
----------------
ygribov wrote:
> I'm afraid he'd want implementation for other sanitizers as well...
Nah, that's fine. As soon as some one needs this functionality in other *san they can add it. 
But if the code were in asan adding it to other *san would be a bit more complex. 


Repository:
  rL LLVM

http://reviews.llvm.org/D16070