[PATCH] D16205: ValueTracking: Put DataLayout reference into the Query structure, NFC.

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 14 15:52:09 PST 2016


joker.eph added a subscriber: joker.eph.
joker.eph added a comment.

IIUC, you just save a pointer argument to `computeKnownBits` right? Is it the only reason for the speedup? Pretty surprising to me.


================
Comment at: lib/Analysis/ValueTracking.cpp:461
@@ -467,1 +460,3 @@
+static bool isValidAssumeForContext(Value *V, const Instruction *CxtI,
+                                    const DominatorTree *DT) {
   Instruction *Inv = cast<Instruction>(V);
----------------
The changes in this function seems unrelated to the DataLayout, it is a cleanup that you could commit separately I feel.



Repository:
  rL LLVM

http://reviews.llvm.org/D16205





More information about the llvm-commits mailing list