[PATCH] D16147: Fix AArch64ConditionOptimizer

[Tim Northover via llvm-commits]

t.p.northover added inline comments.

================
Comment at: lib/Target/AArch64/AArch64ConditionOptimizer.cpp:352-356
@@ +351,7 @@
+    for (int i = 0; i < 2 && !isNZCVLiveOut; ++i)
+      for (auto SuccBB : BBs[i]->successors())
+        if (SuccBB->isLiveIn(AArch64::NZCV)) {
+          isNZCVLiveOut = true;
+          break;
+        }
+    if (isNZCVLiveOut)
----------------
Wouldn't this be better off at the top of findSuitableCompare? We wouldn't need the fairly weird logic to look through both BBs and would get the short-circuiting automatically.


http://reviews.llvm.org/D16147