[PATCH] D16196: [test-suite] Add HOME to test env under lit
Chad Rosier via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 14 12:49:48 PST 2016
mcrosier added a comment.
In http://reviews.llvm.org/D16196#327233, @MatzeB wrote:
> As for the sqlite3 issue: Maybe we should just patch it not check for the home directory and continue anyway. It's always unfortunate if we have to modify the existing benchmarks and it has the risk that the next person putting a newer version of sqlite3 in there will miss the patches. The latter point can be mitigated by documenting the changes in a README-LLVM in the benchmark directory I guess.
I'm fine with this solution as well. Just let me know which direction you'd prefer to take.
Chad
http://reviews.llvm.org/D16196
More information about the llvm-commits
mailing list