[PATCH] D15740: [mips] Add SHF_MIPS_GPREL flag to the MIPS .sbss and .sdata sections

[Simon Atanasyan via llvm-commits]

atanasyan added inline comments.

================
Comment at: tools/llvm-readobj/ELFDumper.cpp:803
@@ -802,2 +802,3 @@
   LLVM_READOBJ_ENUM_ENT(ELF, SHF_MIPS_NOSTRIP    ),
+  LLVM_READOBJ_ENUM_ENT(ELF, SHF_MIPS_GPREL      ),
   LLVM_READOBJ_ENUM_ENT(ELF, SHF_AMDGPU_HSA_GLOBAL),
----------------
khemant wrote:
> Probably I am not understanding this right,  this flag is in SHF_MASKPROC bit fields. Shouldn't the flag printer (for instance in section printer)  be checking processor printing the section flags ? Adding it here makes any processor that may use the same field not be able to use the enum string other than SHF_MIPS_GPREL.
Good point, thanks. I will fix it.


Repository:
  rL LLVM

http://reviews.llvm.org/D15740