[PATCH] D16201: [ELF/AArch64] - Implemented set of R_AARCH64_TLSDESC_* relocations.

[Rui Ueyama via llvm-commits]

ruiu added inline comments.

================
Comment at: ELF/InputSection.cpp:211
@@ -210,1 +210,3 @@
 
+    if (Body->isTls() && Target->isTlsDescReloc(Type, *Body)) {
+      Target->relocateOne(BufLoc, BufEnd, Type, AddrLoc,
----------------
This needs a comment.

================
Comment at: ELF/OutputSections.cpp:191
@@ -176,1 +190,3 @@
   }
+  if (Out<ELFT>::Got->hasTlsDescEntry())
+    Target->writePltTlsDescEntry(Buf + Off, this->getVA() + Off,
----------------
Ditto

================
Comment at: ELF/OutputSections.cpp:249
@@ -218,1 +248,3 @@
 
+  if (Body && Target->isTlsDescReloc(Type, *Body)) {
+    P->setSymbolAndType(Body->DynamicSymbolTableIndex,
----------------
Ditto

================
Comment at: ELF/Writer.cpp:246
@@ -245,3 +245,3 @@
 
-    if (Body && Body->isTls() && !Target->isTlsDynReloc(Type, *Body))
-      continue;
+    if (Body && Body->isTls()) {
+      if (Target->isTlsDescReloc(Type, *Body)) {
----------------
Ditto


http://reviews.llvm.org/D16201