[PATCH] D16169: [Utils] Fix incorrect dbg.declare store conversion

Keno Fischer via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 14 09:34:29 PST 2016


loladiro added inline comments.

================
Comment at: test/Transforms/Util/store-first-op.ll:13
@@ +12,3 @@
+; is correct.
+; CHECK-NOT: @llvm.dbg.value(metadata %foo* %getU
+  call void @llvm.dbg.declare(metadata %foo* %getU, metadata !3, metadata !6), !dbg !7
----------------
aprantl wrote:
> I would still add a positive check — this way we'll be notified when the testcase needs to be updated.
What kind of positive test are you imagining. In the corrected version, no dbg.* intrinsic is inserted.


Repository:
  rL LLVM

http://reviews.llvm.org/D16169





More information about the llvm-commits mailing list