[PATCH] D15446: [mips] Range check uimm16 and fix several bugs this revealed.

[Daniel Sanders via llvm-commits]

dsanders added a comment.

In http://reviews.llvm.org/D15446#314587, @vkalintiris wrote:

> Almost everything looks good to me. However, I can not get the GNU assembler to accept the new `lui` tests that you changed. Should I use any specific option that I'm not aware of, or perhaps a more recent GCC version?


Well spotted, I hadn't noticed that. We should match the range that GAS accepts but I've also queried whether GAS is doing the right thing since simm16 is closer to what the instruction does (the result is sign extended from 32-bit to register width). At the moment, I think it should accept both simm16 and uimm16 (like addiu) and coerce it to simm16.

I'll correct this patch shortly.


http://reviews.llvm.org/D15446