[PATCH] D15281: [ARMv8-M] [8/9] Add new system registers to ARMv8-M Baseline/Mainline

Tim Northover via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 13 16:14:56 PST 2016


t.p.northover added a comment.

One nit here...


================
Comment at: lib/Target/ARM/ARMISelDAGToDAG.cpp:3765
@@ +3764,3 @@
+      Flags = Flags.drop_front(3);
+      if (Flags.startswith("_"))
+        Flags = Flags.drop_front();
----------------
Won't this allow "basepri_maxns"? Seems a bit inconsistent with the others.


Repository:
  rL LLVM

http://reviews.llvm.org/D15281





More information about the llvm-commits mailing list