[PATCH] D15274: [ARMv8-M] [1/9] Split out ARMv8-A semaphores and atomics and ARMv7-M exclusives as separate features

[Tim Northover via llvm-commits]

t.p.northover accepted this revision.
t.p.northover added a comment.
This revision is now accepted and ready to land.

One tiny nit. Otherwise looks fine.

Tim.


================
Comment at: lib/Target/ARM/ARM.td:79-80
@@ -78,1 +78,4 @@
                                    "Has data barrier (dmb / dsb) instructions">;
+def FeatureV7Exclusives : SubtargetFeature<"v7exclusives", "HasV7Exclusives", "true",
+                                           "Has v7 excluisive (clrex) instructions">;
+def FeatureAcquireRelease : SubtargetFeature<"acquire-release",
----------------
This really does just seem to be clrex, so I'd be a bit more explicit about that rather than implying there are lots of them. FeatureV7Clrex maybe, to also point out that it's v7 that added it?

Also, typo in "excluisive".


Repository:
  rL LLVM

http://reviews.llvm.org/D15274