[PATCH] D16146: Rename fpcmp and timeit custom targets to {fpcmp, timeit}-host.
Matthias Braun via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 13 13:31:10 PST 2016
MatzeB added a comment.
In http://reviews.llvm.org/D16146#326126, @jlebar wrote:
> In http://reviews.llvm.org/D16146#326123, @MatzeB wrote:
>
> > In http://reviews.llvm.org/D16146#326001, @MatzeB wrote:
> >
> > > Yes I am seeing the same problem here but didn't figure out a fix yet. LGTM.
> >
> >
> > Hmm these changes make ninja compile fpcmp and timeit again for me but I still get the warning from ninja about multiple rules to generate tools/XXX.
>
>
> Sorry, race condition, saw this only right after I submitted. Did you start from a completely clean objdir?
Well the commit still improves the situation so no problem. I think the issue disappears for me if I do not mention the full path at the add_custom_command OUTPUT anymore. I will prepare a patch.
Repository:
rL LLVM
http://reviews.llvm.org/D16146
More information about the llvm-commits
mailing list