[llvm] r257663 - Remove bashism from merge.sh: POSIX sh does not have the `function`

Hans Wennborg via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 13 13:09:40 PST 2016


On Wed, Jan 13, 2016 at 11:55 AM, Dimitry Andric <dimitry at andric.com> wrote:
> On 13 Jan 2016, at 20:48, Dimitry Andric via llvm-commits <llvm-commits at lists.llvm.org> wrote:
>>
>> Author: dim
>> Date: Wed Jan 13 13:48:50 2016
>> New Revision: 257663
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=257663&view=rev
>> Log:
>> Remove bashism from merge.sh: POSIX sh does not have the `function`
>> reserved word, and it is even superfluous in bash, for this particular
>> instance.
>>
>> Modified:
>>    llvm/trunk/utils/release/merge.sh
>
> Hi Hans,
>
> Can I merge this to the 3.8 branch? (Using the fixed merge.sh script of course ;-)

I'm OK with that, but I'm thinking maybe the better fix is to change
the shebang in these scripts to "#!/usr/bin/env bash", like in
test-release.sh. For example, tag.sh and export.sh also use 'function'
with #!/bin/sh.

 - Hans


More information about the llvm-commits mailing list