[PATCH] D16108: [ValueTracking] Understand more select patterns in ComputeKnownBits

[Chad Rosier via llvm-commits]

mcrosier accepted this revision.
mcrosier added a comment.
This revision is now accepted and ready to land.

LGTM.  Looks pretty straight forward and you have test coverage for all the cases.

As Matt pointed out, it seems there's many more opportunities here.  I don't know if you plan on implementing additional cases, but if not can you please file a PR with a few comments about follow on work to this patch.

Chad


================
Comment at: test/Analysis/ValueTracking/select-maxbits.ll:63
@@ +62,1 @@
+}
\ No newline at end of file

----------------
Please add a newline.


Repository:
  rL LLVM

http://reviews.llvm.org/D16108