[PATCH] D11885: AMDGPU/SI: Add SI Machine Scheduler

Nicolai Hähnle via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 12 18:42:07 PST 2016


nhaehnle accepted this revision.
nhaehnle added a reviewer: nhaehnle.
nhaehnle added a comment.
This revision is now accepted and ready to land.

Thanks for taking care of those changes!

I'm still only lukewarm to the scheduler because the blocks business seems a bit magical, and it would be nice to have a proper explanation why this is better and (more importantly) why the same cannot be achieved by improving on the existing scheduler with less of a "change the whole world" approach.

That said, the evidence is clearly that there are graphics performance improvements to be had with this scheduler, which I don't think we should keep from people. Furthermore, the change is low risk because it's nice and modular.

So all in all, I believe this should be accepted, and I will commit it soon.


http://reviews.llvm.org/D11885





More information about the llvm-commits mailing list