[PATCH] D15784: Enable 2 warnings on MSVC, turn on StringPooling & intrinsic functions

[Aaron Ballman via llvm-commits]

aaron.ballman added a comment.

In http://reviews.llvm.org/D15784#325256, @ariccio wrote:

> > [...] it was causing a build bot failure for MSVC (2013 I think):
>
>
> ...Clang still builds with Visual Studio 2013? There's a bug right there!


By design. We support the last two major releases (not Updates) to MSVC, so that's 2015 and 2013 these days.

> MSVC 2013's debug-mode headers are not const-correct, which is why the build was failing. Must I add a check for MSVC in the Makefile? I'm not exactly sure how to do that.


Yes, you will have to check that. I'm no CMake expert, but I think you can use if (MSVC14) to test for this; but you'll have to check if (1) that's supported in CMake at all, and (2) if that's supported in the oldest CMake we support. I *think* that's 2.8.8 (at least, that's what our public documentation states).


http://reviews.llvm.org/D15784