[PATCH] D16124: Add to the split module utility an SCC based method which allows not to globalize any local variables.

Sergei Larin via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 12 15:49:57 PST 2016


 In the end it depends on what your linker does. If your linker tracks global symbols, turning locals into globals will not play well even with hidden attribute.

Besides, I want to "add" new functionality, not to change existing one (patch reflects that). It seems like a generic enough feature that people can find useful outside my use case... 

---
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation


> -----Original Message-----
> From: Mehdi AMINI [mailto:mehdi.amini at apple.com]
> Sent: Tuesday, January 12, 2016 5:43 PM
> To: slarin at codeaurora.org; peter at pcc.me.uk
> Cc: mehdi.amini at apple.com; mehdi_amini at apple.com;
> tobias at codeaurora.org; llvm-commits at lists.llvm.org
> Subject: Re: [PATCH] D16124: Add to the split module utility an SCC based
> method which allows not to globalize any local variables.
> 
> joker.eph added a comment.
> 
> It looks like we should set visibility hidden when turning a local into a global.
> 
> 
> http://reviews.llvm.org/D16124
> 
> 




More information about the llvm-commits mailing list