[PATCH] D15401: Refactor threshold computation for inline cost analysis

[Easwaran Raman via llvm-commits]

eraman added a comment.

Chandler, if you don't have any other comments, I'll check this in tomorrow.


================
Comment at: lib/Analysis/InlineCost.cpp:197
@@ -164,3 +196,3 @@
   CallAnalyzer(const TargetTransformInfo &TTI, AssumptionCacheTracker *ACT,
                Function &Callee, int Threshold, CallSite CSArg)
     : TTI(TTI), ACT(ACT), F(Callee), CandidateCS(CSArg), Threshold(Threshold),
----------------
davidxl wrote:
> A related follow up that can be done:
> 
> 1) change the parameter name to DefaultThreshold
> 2) Save the default threshold value in a different member so that it is not overriden by updatethreshold
> 3) Use the default threshold when recurisively analyizing the indirect call (instead of a constant).
> 
> (Not required for this patch).
Ok, will address these in a separate patch.


http://reviews.llvm.org/D15401