[llvm] r256156 - [llvm-objdump] Use appropriate helper. NFC.

[David Blaikie via llvm-commits]

On Tue, Jan 12, 2016 at 11:57 AM, Davide Italiano <davide at freebsd.org>
wrote:

> On Tue, Jan 12, 2016 at 11:45 AM, David Blaikie <dblaikie at gmail.com>
> wrote:
> >
> >
> > On Mon, Dec 21, 2015 at 6:10 AM, Davide Italiano via llvm-commits
> > <llvm-commits at lists.llvm.org> wrote:
> >>
> >> Author: davide
> >> Date: Mon Dec 21 08:10:54 2015
> >> New Revision: 256156
> >>
> >> URL: http://llvm.org/viewvc/llvm-project?rev=256156&view=rev
> >> Log:
> >> [llvm-objdump] Use appropriate helper. NFC.
> >
> >
> > Test case?
> >
>
> test/tools/llvm-objdump/invalid-input.test should somehow cover this,
> I guess.


But there were no changes for that test when this commit was made - so it
doesn't seem like it would be testing the change you made (in the sense
that it wouldn't catch a regression caused by reverting this patch).

What would fail if I revert this patch or otherwise broke the functionality
you were fixing in this commit?


> It's a little bit weirder than that. For some reason (I'm not
> aware of), MachO has a different path for opening the binary and
> parsing it so it's not super easy to hit the code I changed.


Not sure I follow - we can have MachO binaries committed to ensure the
MachO codepath remains functioning (or non-MachO for the other side too).


> I also
> guess this code can be eventually removed (or even better, merged with
> the "main" codepath for ELF/COFF) but a non-trivial amount of work is
> required to make it happen. It's in my TODO list but nowhere near the
> top, sorry.
>
> --
> Davide
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160112/d0b4e606/attachment-0001.html>