[PATCH] D16005: Display detailed profile summary in llvm-profdata tool

[David Li via llvm-commits]

davidxl added inline comments.

================
Comment at: test/tools/llvm-profdata/general.proftext:66
@@ +65,3 @@
+
+# RUN: llvm-profdata show --detailed-summary %t.profdata | FileCheck %s -check-prefix=DETAILED-SUMMARY
+# DETAILED-SUMMARY: Detailed summary:
----------------
The default cutoffs only have 3 percentiles, how come the dump shows more?

================
Comment at: test/tools/llvm-profdata/general.proftext:78
@@ +77,3 @@
+
+# RUN: llvm-profdata show --detailed-summary --detailed-summary-cutoffs=600000 %t.profdata | FileCheck %s -check-prefix=DETAILED-SUMMARY-2
+# DETAILED-SUMMARY-2: 2 blocks with count >= 576460752303423488 account for 60 percentage of the total counts.
----------------
Add a test with more than one explicit cutoffs?

================
Comment at: tools/llvm-profdata/llvm-profdata.cpp:132
@@ +131,3 @@
+
+std::vector<ProfileSummaryEntry> ProfileSummary::getDetailedSummary() {
+  if (!DetailedSummaryCutoffs.empty() && DetailedSummary.empty())
----------------
Return vector<..>&.

================
Comment at: tools/llvm-profdata/llvm-profdata.cpp:488
@@ +487,3 @@
+      cl::desc(
+          "Cutoff percentages (times 10000) for generating detailed summary"),
+      cl::value_desc("800000,901000,999999"));
----------------
the scale is defined to be 1000000


http://reviews.llvm.org/D16005