[PATCH] D16005: Display detailed profile summary in llvm-profdata tool

Easwaran Raman via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 12 13:50:43 PST 2016


eraman added inline comments.

================
Comment at: tools/llvm-profdata/llvm-profdata.cpp:83
@@ +82,3 @@
+    MaxBlockCount = Count;
+  NumBlocks++;
+  CountFrequencies[Count]++;
----------------
davidxl wrote:
> so -- for option part, using float is fine. What I am concerned is PorgramSummaryEntry has a float member. Eventually, I will need to write those entries to Indexed Profile header, so an integer representation there is better.
Ok, I've changed even the options to use ints. Main issue is whether the help message makes it clear what the numbers mean.


http://reviews.llvm.org/D16005





More information about the llvm-commits mailing list