[PATCH] D16061: [Utils] Insert DW_OP_bit_piece when only describing part of the variable

Adrian Prantl via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 12 12:58:54 PST 2016


aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

Accepted with minor comments.


================
Comment at: lib/Transforms/Utils/Local.cpp:1056
@@ +1055,3 @@
+  if (ExtendedArg) {
+    // We're now only describing a subset of the variable
+    SmallVector<uint64_t, 3> NewDIExpr;
----------------
Please add a comment explaining why and why the piece has to be smaller than the variable.
Nitpick: the clang coding standards prefer full sentences as comments, with a trailing '.'.


Repository:
  rL LLVM

http://reviews.llvm.org/D16061





More information about the llvm-commits mailing list