[llvm] r256156 - [llvm-objdump] Use appropriate helper. NFC.

[Davide Italiano via llvm-commits]

On Tue, Jan 12, 2016 at 11:45 AM, David Blaikie <dblaikie at gmail.com> wrote:
>
>
> On Mon, Dec 21, 2015 at 6:10 AM, Davide Italiano via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
>>
>> Author: davide
>> Date: Mon Dec 21 08:10:54 2015
>> New Revision: 256156
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=256156&view=rev
>> Log:
>> [llvm-objdump] Use appropriate helper. NFC.
>
>
> Test case?
>

test/tools/llvm-objdump/invalid-input.test should somehow cover this,
I guess. It's a little bit weirder than that. For some reason (I'm not
aware of), MachO has a different path for opening the binary and
parsing it so it's not super easy to hit the code I changed. I also
guess this code can be eventually removed (or even better, merged with
the "main" codepath for ELF/COFF) but a non-trivial amount of work is
required to make it happen. It's in my TODO list but nowhere near the
top, sorry.

--
Davide