[PATCH] D14899: fixing return value of performScalarPRE() ignored issue

Wenxiang Qiu via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 12 11:24:11 PST 2016


vincentqiuuu abandoned this revision.
vincentqiuuu added a comment.

After studying the test case that failed and GVN.cpp, I found that int the function processNonLocalLoad(LoadInst *LI), not taking the return value of performScalarPRE(I) into account is actually correct. It's not a bug because performScalarPRE(I) is just a step of analyzing when the first operand of the LoadInst is a GEP, which means the LoadInst follows a GEP. performScalarPRE(I) can return true (the GEP is thus eliminated) whereas the LoadInst is not eliminated and thus processNonLocalLoad(LoadInst *LI) should return false.


http://reviews.llvm.org/D14899





More information about the llvm-commits mailing list