[PATCH] D16095: [Polly] Prepare unit tests for update to ISL 0.16 (WIP)

[Michael Kruse via llvm-commits]

Meinersbur added a comment.

In http://reviews.llvm.org/D16095#324622, @grosser wrote:

> > > Regarding the script, I think it would be great if the --check-include options could eventually (not necessary for this commit) be auto-derived.
>
> > 
>
> > 
>
> > Can you share your idea how this autodetection could work?
>
>
> It seems you have only a couple of options Statements, AssumedContext, InvariantAccesses. Most (all) of these options could possibly be identified
>  by looking for specific string in the CHECK lines. E.g., for AssumedContext.


This is extremely fragile. Just imagine we change the -analyze output. The script would need to recognize the old and new format. 
And because we are not upgrading all tests at once, all the formats of the past, including degenerated ones. Also, this would not work with new test cases. You'd need to first write a correct test case manually before one can use the script.

> > >   I think this is would be desirable.

> 

> > 

> 

> > 

> 

> > Why?

> 

> 

> If I would like to update a test case using your script, it's nicer if it just works rather than me having to figure out all options.


We might also standardize unit tests. That is, tests in DependenceInfo have all dependences checked, ScoopInfo the Statements, etc.


http://reviews.llvm.org/D16095