[PATCH] D16042: AVX512: VPMOVAPS (load) intrinsic implementation.
Elena Demikhovsky via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 12 01:28:25 PST 2016
delena accepted this revision.
delena added a comment.
Some minor comments inside.
LGTM.
================
Comment at: lib/Target/X86/X86ISelLowering.cpp:17609
@@ +17608,3 @@
+ MVT VT = Op.getSimpleValueType();
+ MachineMemOperand *MMO = cast<MemIntrinsicSDNode>(Op)->getMemOperand();
+
----------------
Please add assertion for dyn_cast<MemIntrinsicSDNode>
================
Comment at: lib/Target/X86/X86ISelLowering.h:842
@@ +841,3 @@
+ /// to a MemIntrinsicNode (touches memory). If this is the case, it returns
+ /// true and store the intrinsic information into the IntrinsicInfo that was
+ /// passed to the function.
----------------
stores
Repository:
rL LLVM
http://reviews.llvm.org/D16042
More information about the llvm-commits
mailing list