[PATCH] D16095: [Polly] Prepare unit tests for update to ISL 0.16 (WIP)

Tobias Grosser via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 11 22:42:23 PST 2016


grosser added a comment.

Hi Michael,

the patch looks to me very sensible. I would be generally comfortable to commit something like this. What are the remaining changes you had in mind?

Regarding the script, I think it would be great if the --check-include options could eventually (not necessary for this commit) be auto-derived. Also, does --check-position=autodetect work after this initial formatting? If both would, the majority of the options in https://raw.githubusercontent.com/Meinersbur/polly/update_test/test/CMakeLists.txt would not be necessary any more, right? I think this is would be desirable.


================
Comment at: test/ScopInfo/remarks.ll:3
@@ -2,3 +2,1 @@
 ;
-; CHECK: remark: test/ScopInfo/remarks.c:4:7: SCoP begins here.
-; CHECK: remark: test/ScopInfo/remarks.c:8:5: Finite loop assumption: [M, N, Debug] -> {  : M >= 0 or (M <= -2 and N <= 0) or (M = -1 and N <= 0) }
----------------
Why was this line dropped?


http://reviews.llvm.org/D16095





More information about the llvm-commits mailing list