[PATCH] D15887: [Power9] Implement new vector permute, count zero instructions

[Chuang-Yu Cheng via llvm-commits]

cycheng added inline comments.

================
Comment at: lib/Target/PowerPC/PPCInstrAltivec.td:1217
@@ +1216,3 @@
+
+def HasP9Altivec : Predicate<"PPCSubTarget->hasP9Altivec()">;
+let Predicates = [HasP9Altivec] in {
----------------
nemanjai wrote:
> Since P9 has fewer optional features, do we need P9Altivec, P9Vector, etc.? Or perhaps we would like a single predicate and a single feature that will give us everything? I suppose that AES and DFP are still optional, but any additions therein can use the P9 predicate along with the respective predicate.
Agree. By the way, how can I know an instruction is optional instruction?

================
Comment at: lib/Target/PowerPC/PPCSubtarget.h:95
@@ -94,2 +94,3 @@
   bool HasP8Crypto;
+  bool HasP9Altivec;
   bool HasFCPSGN;
----------------
nemanjai wrote:
> Was the implementation of this feature in PPC.td intentionally omitted? Is the plan to implement setting this feature using -mattr at a later time?
Thanks! It looks like I have to add "FeatureP9*" in PPC.td, I didn't notice it, I will fix it later.


http://reviews.llvm.org/D15887