[PATCH] D15082: Fix the cross compilation of unit tests. NFC

Alexey Samsonov via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 11 16:10:01 PST 2016


samsonov added inline comments.

================
Comment at: lib/asan/tests/CMakeLists.txt:40
@@ +39,3 @@
+set(ASAN_UNITTEST_COMMON_LINKFLAGS
+  "${COMPILER_RT_UNITTEST_LINKFLAGS}")
+
----------------
sgundapa wrote:
> samsonov wrote:
> > Why do you need quotes here?
> I guess, it is generally safe to wrap a variable with quotes which holds a value with spaces/colons. Let me know if you think otherwise.
> I am not an expert in CMake
>  
If COMPILER_RT_UNITTEST_LINKFLAGS is a list (which it's likely is, all other similar varialbes are), then you probably don't want to escape semicolons, which are treated as items delimiters.


http://reviews.llvm.org/D15082





More information about the llvm-commits mailing list