[PATCH] D16074: Make sure that any new and optimized objects created during GlobalOPT copy all the attributes from the base object.

[Sergei Larin via llvm-commits]

Yes,  We had this discussion with Chris (see more context here)

http://lists.llvm.org/pipermail/llvm-dev/2015-September/090923.html

...but I read his final comment as a comment, not as a hard suggestion... Partially for that reason I propose something that looks for me as a simpler solution, but you are right, I really want to make sure enough opinions are expressed.

  In your current universe - will this change cause any issues? Will it matter at all? Would it help anything?

 

---
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation

> -----Original Message-----
> From: Mehdi AMINI [mailto:mehdi.amini at apple.com]
> Sent: Monday, January 11, 2016 2:22 PM
> To: slarin at codeaurora.org; james.molloy at arm.com;
> mehdi_amini at apple.com
> Cc: mehdi.amini at apple.com; rafael.espindola at gmail.com;
> tobias at codeaurora.org; llvm-commits at lists.llvm.org
> Subject: Re: [PATCH] D16074: Make sure that any new and optimized objects
> created during GlobalOPT copy all the attributes from the base object.
> 
> joker.eph added a comment.
> 
> I know that global opt is not conservative enough, but I thought the
> conservative fix was to update any pass that "optimize" with variable with
> section and prevent it to do so, i.e. I had in mind what Chris wrote here:
> http://lists.llvm.org/pipermail/llvm-dev/2015-September/090587.html
> (Note: I'm not opposed to this, I'm just not knowledgeable enough about
> what can go wrong)
> 
> 
> http://reviews.llvm.org/D16074
> 
>