[PATCH] D15600: AArch64: Add option to use shared epilogues in compiler-rt

Ahmed Bougacha via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 11 11:55:20 PST 2016


ab added a comment.

In http://reviews.llvm.org/D15600#314648, @kristof.beyls wrote:

> - My gut feel is that if over time we want to modify epilogues; a scheme where the compiler still emits the epilogues is the most flexible. Retaining all versions of epilogues in compiler-rt potentially required by all LLVM revisions ever used may end up being a bookkeeping nightmare.


We don't claim to support non-matching compiler-rt versions though, do we? I thought users/distros were supposed to always use the correct version.


================
Comment at: lib/Target/AArch64/AArch64FrameLowering.cpp:856
@@ +855,3 @@
+  unsigned OpCode = InsertBefore->getOpcode();
+  if (OpCode != AArch64::RET && OpCode != AArch64::RET_ReallyLR)
+    return false;
----------------
When does RET occur here? I can't remember a way to bypass RET_ReallyLR.


Repository:
  rL LLVM

http://reviews.llvm.org/D15600





More information about the llvm-commits mailing list