[PATCH] D16070: [asan] Optionally print reproducer cmdline in ASan reports.
Maxim Ostapenko via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 11 09:30:08 PST 2016
m.ostapenko added inline comments.
================
Comment at: lib/asan/asan_report.cc:246
@@ +245,3 @@
+ Printf("\nReproducer cmdline: ");
+ for (int i = 0; argv[i] != 0; ++i)
+ Printf("%s ", argv[i]);
----------------
ygribov wrote:
> size_t?
size_t is not accessible from ASan code... will use uptr like in many other places.
================
Comment at: lib/sanitizer_common/sanitizer_common.h:285
@@ -284,2 +284,3 @@
void ReExec();
+void GetArgsAndEnv(char*** argv, char*** envp);
bool StackSizeIsUnlimited();
----------------
ygribov wrote:
> Stars bind to right.
This was just copied from sanitizer_linux.cc. Perhaps I should fix stars binding there as well.
Repository:
rL LLVM
http://reviews.llvm.org/D16070
More information about the llvm-commits
mailing list