[PATCH] D16064: Write AArch64 big endian data fixup entries as BE.

[James Molloy via llvm-commits]

jmolloy added a subscriber: jmolloy.
jmolloy added a comment.

Hi Keith,

I've got some style comments, but apart from that I think this looks sensible.

James


================
Comment at: lib/Target/AArch64/MCTargetDesc/AArch64AsmBackend.cpp:35
@@ -32,3 +34,3 @@
 public:
-  AArch64AsmBackend(const Target &T) : MCAsmBackend() {}
+  AArch64AsmBackend(const Target &T, bool IsLittleEndian) : MCAsmBackend(), IsLittleEndian(IsLittleEndian) {}
 
----------------
This line is too long.

================
Comment at: lib/Target/AArch64/MCTargetDesc/AArch64AsmBackend.cpp:86
@@ -83,1 +85,3 @@
+
+  unsigned getFixupKindContainerSizeBytes(unsigned Kind) const;
 };
----------------
I'd prefer "getFixupKindContainerSizeInBytes", as the "InBytes" suffix is similar to what we have elsewhere in LLVM and it's clearer.


http://reviews.llvm.org/D16064