[PATCH] D15982: [rs4gc] Optionally directly relocated vector of pointers

[Manuel Jacob via llvm-commits]

mjacob accepted this revision.
mjacob added a comment.
This revision is now accepted and ready to land.

LGTM.

Maybe you could move the caching to the lambda. However I'm fine with it if you had good reasons not to do so.


================
Comment at: lib/Transforms/Scalar/RewriteStatepointsForGC.cpp:1322-1327
@@ -1321,6 +1321,8 @@
+  
   // All gc_relocate are set to i8 addrspace(1)* type. We originally generated
   // unique declarations for each pointer type, but this proved problematic
   // because the intrinsic mangling code is incomplete and fragile.  Since
   // we're moving towards a single unified pointer type anyways, we can just
   // cast everything to an i8* of the right address space.  A bitcast is added
   // later to convert gc_relocate to the actual value's type. 
+  auto getGCRelocateDecl = [&] (Type *Ty) {
----------------
This comment is a bit inaccurate now.


http://reviews.llvm.org/D15982