[PATCH] D15082: Fix the cross compilation of unit tests. NFC

[Alexey Samsonov via llvm-commits]

samsonov added inline comments.

================
Comment at: cmake/Modules/AddCompilerRT.cmake:174
@@ -170,4 +173,3 @@
 # Unittests support.
-set(COMPILER_RT_GTEST_PATH ${LLVM_MAIN_SRC_DIR}/utils/unittest/googletest)
-set(COMPILER_RT_GTEST_SOURCE ${COMPILER_RT_GTEST_PATH}/src/gtest-all.cc)
-set(COMPILER_RT_GTEST_CFLAGS
+set(COMPILER_RT_GOOGLE_UNITTEST_PATH ${LLVM_MAIN_SRC_DIR}/utils/unittest/googletest)
+set(COMPILER_RT_GOOGLE_UNITTEST_SOURCE ${COMPILER_RT_GOOGLE_UNITTEST_PATH}/src/gtest-all.cc)
----------------
No, please leave COMPILER_RT_GTEST_* variables intact: GTest is the name of unittest framework.

================
Comment at: lib/asan/tests/CMakeLists.txt:40
@@ +39,3 @@
+set(ASAN_UNITTEST_COMMON_LINKFLAGS
+  "${COMPILER_RT_UNITTEST_LINKFLAGS}")
+
----------------
Why do you need quotes here?


http://reviews.llvm.org/D15082