[PATCH] D15607: [sanitizer] [msan] Fix origin store of array types

[Evgeniy Stepanov via llvm-commits]

eugenis added inline comments.

================
Comment at: lib/Transforms/Instrumentation/MemorySanitizer.cpp:733
@@ +732,3 @@
+                Cmp, &*IRB.GetInsertPoint(), false, MS.OriginStoreWeights);
+            IRB.SetInsertPoint(CheckTerm);
+          }
----------------
This code seems to build nested if() blocks, effectively testing that all shadow elements are non-null. This is wrong, it should test that any of those is non-null. And even that is a rough approximation.

Would it be enough to change the isa<StructType> test above to isAggregateType() ?



http://reviews.llvm.org/D15607