[PATCH] D16013: Make Driver::BuildJobsForAction return an InputInfo, instead of using an outparam.

Eric Christopher via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 8 14:21:26 PST 2016


echristo added a comment.

One inline comment. Basic idea is that having the a "result" also be an "inputinfo" is confusing. Not that I have a better name for InputInfo, but if you come up with one...


================
Comment at: include/clang/Driver/Driver.h:383
@@ -382,2 +382,3 @@
   /// BuildJobsForAction - Construct the jobs to perform for the
   /// action \p A.
+  InputInfo BuildJobsForAction(Compilation &C, const Action *A,
----------------
Update the comment?


http://reviews.llvm.org/D16013





More information about the llvm-commits mailing list