[PATCH] D15962: [WinEH] Verify consistent funclet unwind exits

Joseph Tremoulet via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 8 14:14:36 PST 2016


JosephTremoulet added inline comments.

================
Comment at: lib/IR/Verifier.cpp:3117
@@ +3116,3 @@
+        do {
+          if (ExitedPad == &FPI) {
+            ExitsFPI = true;
----------------
andrew.w.kaylor wrote:
> I haven't taken the time to think through it yet but you may know, is it possible to skip over FPI and/or UnwindParent below while walking the pad-parent chain?  I think I could make some IR that would do that for just this function.  I just don't know if it would be flagged as invalid somewhere else.
I did give it some thought, and yes my goal was that any such cases would be quiet here but would get flagged in visitEHPadPredecessors when looking at the same unwind edge from its successor.


http://reviews.llvm.org/D15962





More information about the llvm-commits mailing list