[PATCH] D16009: [lld]Non-MachO references shouldn't assert when checking for TLV.
Eric Christopher via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 8 13:32:30 PST 2016
echristo added a subscriber: echristo.
================
Comment at: lib/ReaderWriter/MachO/ArchHandler_x86_64.cpp:63
@@ -62,2 +62,3 @@
bool isTLVAccess(const Reference &ref) const override {
- assert(ref.kindNamespace() == Reference::KindNamespace::mach_o);
+ if (ref.kindNamespace() != Reference::KindNamespace::mach_o)
+ return false;
----------------
Can you add a comment explaining how you could get here? That said, is the check worth it now? i.e. do we really need the early exit?
Repository:
rL LLVM
http://reviews.llvm.org/D16009
More information about the llvm-commits
mailing list