[llvm] r257180 - How to close a review manually.
Paul Robinson via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 8 09:05:12 PST 2016
Author: probinson
Date: Fri Jan 8 11:05:12 2016
New Revision: 257180
URL: http://llvm.org/viewvc/llvm-project?rev=257180&view=rev
Log:
How to close a review manually.
Modified:
llvm/trunk/docs/Phabricator.rst
Modified: llvm/trunk/docs/Phabricator.rst
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/docs/Phabricator.rst?rev=257180&r1=257179&r2=257180&view=diff
==============================================================================
--- llvm/trunk/docs/Phabricator.rst (original)
+++ llvm/trunk/docs/Phabricator.rst Fri Jan 8 11:05:12 2016
@@ -136,7 +136,7 @@ reviewers, the ``Differential Revision``
arc commit --revision D<Revision>
-When committing an LLVM change that has been reviewed using
+When committing a change that has been reviewed using
Phabricator, the convention is for the commit message to end with the
line:
@@ -153,6 +153,12 @@ This allows people reading the version h
context. This also allows Phabricator to detect the commit, close the
review, and add a link from the review to the commit.
+If you use ``git`` or ``svn`` to commit the change and forget to add the line
+to your commit message, you should close the review manually. In the web UI,
+under "Leap Into Action" put the SVN revision number in the Comment, set the
+Action to "Close Revision" and click Submit. Note the review must have been
+Accepted first.
+
Abandoning a change
-------------------
More information about the llvm-commits
mailing list