[llvm] r257122 - Add some testing for thumb1 and thumb2 inline asm immediate constraints

[Eric Christopher via llvm-commits]

For the record this fixes a couple of low hanging fruit, but it could
easily use a going over and more tests.

On Thu, Jan 7, 2016 at 4:38 PM Eric Christopher via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: echristo
> Date: Thu Jan  7 18:34:44 2016
> New Revision: 257122
>
> URL: http://llvm.org/viewvc/llvm-project?rev=257122&view=rev
> Log:
> Add some testing for thumb1 and thumb2 inline asm immediate constraints
> and fix a couple of bugs on inspection.
>
> Also fixes PR26061.
>
> Added:
>     llvm/trunk/test/CodeGen/ARM/inlineasm-imm-thumb.ll
>     llvm/trunk/test/CodeGen/ARM/inlineasm-imm-thumb2.ll
> Modified:
>     llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp
>
> Modified: llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp?rev=257122&r1=257121&r2=257122&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp (original)
> +++ llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp Thu Jan  7 18:34:44 2016
> @@ -11475,7 +11475,7 @@ void ARMTargetLowering::LowerAsmOperandF
>          return;
>
>        case 'J':
> -        if (Subtarget->isThumb()) {  // FIXME thumb2
> +        if (Subtarget->isThumb1Only()) {
>            // This must be a constant between -255 and -1, for negated ADD
>            // immediates. This can be used in GCC with an "n" modifier that
>            // prints the negated value, for use with SUB instructions. It
> is
> @@ -11544,7 +11544,7 @@ void ARMTargetLowering::LowerAsmOperandF
>          return;
>
>        case 'M':
> -        if (Subtarget->isThumb()) { // FIXME thumb2
> +        if (Subtarget->isThumb1Only()) {
>            // This must be a multiple of 4 between 0 and 1020, for
>            // ADD sp + immediate.
>            if ((CVal >= 0 && CVal <= 1020) && ((CVal & 3) == 0))
>
> Added: llvm/trunk/test/CodeGen/ARM/inlineasm-imm-thumb.ll
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/ARM/inlineasm-imm-thumb.ll?rev=257122&view=auto
>
> ==============================================================================
> --- llvm/trunk/test/CodeGen/ARM/inlineasm-imm-thumb.ll (added)
> +++ llvm/trunk/test/CodeGen/ARM/inlineasm-imm-thumb.ll Thu Jan  7 18:34:44
> 2016
> @@ -0,0 +1,20 @@
> +; RUN: llc -mtriple=thumbv5-none-linux-gnueabi -no-integrated-as %s -o
> /dev/null
> +
> +; Test thumb-mode "I" constraint, for any Data Processing immediate.
> +define void @testI() {
> +       tail call void asm sideeffect ".word $0", "I"( i32 255 ) nounwind
> +       ret void
> +}
> +
> +; Test thumb-mode "J" constraint, for compatibility with unknown use in
> GCC.
> +define void @testJ() {
> +       tail call void asm sideeffect ".word $0", "J"( i32 -254 ) nounwind
> +       ret void
> +}
> +
> +; Test thumb-mode "L" constraint, for negated Data Processing immediates.
> +define void @testL() {
> +       tail call void asm sideeffect ".word $0", "L"( i32 -7 ) nounwind
> +       ret void
> +}
> +
>
> Added: llvm/trunk/test/CodeGen/ARM/inlineasm-imm-thumb2.ll
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/ARM/inlineasm-imm-thumb2.ll?rev=257122&view=auto
>
> ==============================================================================
> --- llvm/trunk/test/CodeGen/ARM/inlineasm-imm-thumb2.ll (added)
> +++ llvm/trunk/test/CodeGen/ARM/inlineasm-imm-thumb2.ll Thu Jan  7
> 18:34:44 2016
> @@ -0,0 +1,31 @@
> +; RUN: llc -mtriple=thumbv7-linux-gnu -no-integrated-as %s -o /dev/null
> +
> +; Test thumb2-mode "I" constraint, for any Data Processing immediate.
> +define i32 @testI(i32 %x) {
> +       %y = call i32 asm "add $0, $1, $2", "=r,r,I"( i32 %x, i32 65280 )
> nounwind
> +       ret i32 %y
> +}
> +
> +; Test thumb2-mode "J" constraint, for compatibility with unknown use in
> GCC.
> +define void @testJ() {
> +       tail call void asm sideeffect ".word $0", "J"( i32 4080 ) nounwind
> +       ret void
> +}
> +
> +; Test thumb2-mode "K" constraint, for bitwise inverted Data Processing
> immediates.
> +define void @testK() {
> +       tail call void asm sideeffect ".word $0", "K"( i32 16777215 )
> nounwind
> +       ret void
> +}
> +
> +; Test thumb2-mode "L" constraint, for negated Data Processing immediates.
> +define void @testL() {
> +       tail call void asm sideeffect ".word $0", "L"( i32 -65280 )
> nounwind
> +       ret void
> +}
> +
> +; Test thumb2-mode "M" constraint, for value between 0 and 32.
> +define i32 @testM(i32 %x) {
> +       %y = call i32 asm "lsl $0, $1, $2", "=r,r,M"( i32 %x, i32 31 )
> nounwind
> +       ret i32 %y
> +}
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160108/acb5c7c3/attachment.html>