[PATCH] D15940: Add verifier pass for finding GC relocation bugs

[Manuel Jacob via llvm-commits]

mjacob added a comment.

Have you run clang-format on the source code? I saw some consecutive empty lines which should be removed by clang-format?


================
Comment at: lib/IR/SafepointIRVerifier.cpp:77
@@ +76,3 @@
+  void getAnalysisUsage(AnalysisUsage &AU) const override {
+    AU.setPreservesCFG();
+    AU.setPreservesAll();
----------------
This is already implied by `AU.setPreservesAll();`

================
Comment at: lib/IR/SafepointIRVerifier.cpp:190
@@ +189,3 @@
+
+/// TransferInstruction composed over a whole BasicBlock.
+static void TransferBlock(const BasicBlock *BB,
----------------
Can you restate this comment, so it tells me what it is for instead of which funtion it calls?

================
Comment at: lib/IR/SafepointIRVerifier.cpp:223-224
@@ +222,4 @@
+
+  if (PrintOnly)
+    dbgs() << "Verifying gc pointers in function: " << F.getName() << "\n";
+
----------------
I think this should be in a DEBUG(...) and not guarded by PrintOnly.


http://reviews.llvm.org/D15940