[PATCH] D15725: Ensure safestack overflow test doesn't segfault

Dimitry Andric via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 7 14:18:16 PST 2016


dim added a comment.

In http://reviews.llvm.org/D15725#319932, @zatrazz wrote:

> Another way would be to adjust fct to no pass the possible stack end by writing 6*sizeof(int) instead. I have no preference, so this change also LGTM.


OK.

> I was not able to reproduce it yet on aarch64, but we can check on the faulty system (the buildbot) by removing the stable-runtime requirement.


Shall I then remove the `// REQUIRES: stable-runtime` line from `compiler-rt/trunk/test/safestack/overflow.c` as part of this fix?


http://reviews.llvm.org/D15725





More information about the llvm-commits mailing list