[lld] r257096 - Revert "Remove unnecessary type casts."

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 7 12:53:30 PST 2016


Author: ruiu
Date: Thu Jan  7 14:53:30 2016
New Revision: 257096

URL: http://llvm.org/viewvc/llvm-project?rev=257096&view=rev
Log:
Revert "Remove unnecessary type casts."

This reverts commit r257080 because it caused GCC to emit "enumeral
and non-enumeral type in conditional expression" warning.

Modified:
    lld/trunk/ELF/OutputSections.cpp

Modified: lld/trunk/ELF/OutputSections.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/OutputSections.cpp?rev=257096&r1=257095&r2=257096&view=diff
==============================================================================
--- lld/trunk/ELF/OutputSections.cpp (original)
+++ lld/trunk/ELF/OutputSections.cpp Thu Jan  7 14:53:30 2016
@@ -1161,7 +1161,8 @@ template <class ELFT> void MergeOutputSe
 
 template <class ELFT>
 StringTableSection<ELFT>::StringTableSection(StringRef Name, bool Dynamic)
-    : OutputSectionBase<ELFT>(Name, SHT_STRTAB, Dynamic ? SHF_ALLOC : 0),
+    : OutputSectionBase<ELFT>(Name, SHT_STRTAB,
+                              Dynamic ? (uintX_t)SHF_ALLOC : 0),
       Dynamic(Dynamic) {
   this->Header.sh_addralign = 1;
 }
@@ -1234,7 +1235,7 @@ SymbolTableSection<ELFT>::SymbolTableSec
     SymbolTable<ELFT> &Table, StringTableSection<ELFT> &StrTabSec)
     : OutputSectionBase<ELFT>(StrTabSec.isDynamic() ? ".dynsym" : ".symtab",
                               StrTabSec.isDynamic() ? SHT_DYNSYM : SHT_SYMTAB,
-                              StrTabSec.isDynamic() ? SHF_ALLOC : 0),
+                              StrTabSec.isDynamic() ? (uintX_t)SHF_ALLOC : 0),
       Table(Table), StrTabSec(StrTabSec) {
   this->Header.sh_entsize = sizeof(Elf_Sym);
   this->Header.sh_addralign = ELFT::Is64Bits ? 8 : 4;




More information about the llvm-commits mailing list