[PATCH] D15943: Add support for headerpad_max_install_names cmdline option

[Pete Cooper via llvm-commits]

pete added inline comments.

================
Comment at: lib/ReaderWriter/MachO/MachONormalizedFile.h:289-290
@@ -288,3 +288,4 @@
 /// Takes in-memory normalized view and writes a mach-o object file.
-std::error_code writeBinary(const NormalizedFile &file, StringRef path);
+std::error_code writeBinary(const NormalizedFile &file, StringRef path,
+                            const MachOLinkingContext &ctx);
 
----------------
kledzik wrote:
> This is a design change.  writeBinary() has only depended on the NormalizedFile object - not the LinkingContext.  That is, for extra info like this, we add a new field to NormalizedFile.
> 
Yeah, i was wondering whether the right thing was to add a new field or pass in the context.  Thanks for clarifying the intended dependencies of writeBinary.  I'll make this change now.


http://reviews.llvm.org/D15943