[PATCH] D15798: Fix for Bug 24852 (crash with -debug -instcombine)

Than McIntosh via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 7 08:36:38 PST 2016


thanm added a comment.

Updated patch with C++ unit test instead of *.ll test.

Question: I looked around for a style guide or "how to" for writing new C++ unit tests but could not find one. Did I miss it, or maybe such a guide doesn't exist?

I had to choose between A) constructing the IR directly with IRBuilder or equivalent and B) writing assembly, invoking parseAssemblyString, then grabbing pointers to instructions. I chose option "A", hope that is ok.


http://reviews.llvm.org/D15798





More information about the llvm-commits mailing list