[PATCH] D15230: [BranchFolding] Merge MMOs during tail merge

Geoff Berry via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 7 07:00:23 PST 2016


gberry added a comment.

I don't think that is correct.  If you look at the body of MachineInstr::mergeMemRefsWith() after Philip's change, it is only merging in the case where the MMO lists are the same.  I believe his intention was for you to refactor this change by making a similar change in mergeMemRefsWith() instead of in TryTailMergeBlocks()


http://reviews.llvm.org/D15230





More information about the llvm-commits mailing list